feat: add expiration transaction policy
#1583
Open
+316
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hal3e
requested review from
digorithm,
MujkicA,
segfault-magnet and
Salka1988
as code owners
MujkicA
previously approved these changes
Jan 24, 2025
| @@ -248,6 +260,8 @@ pub trait Transaction: | |||
|
|
|||
| fn with_maturity(self, maturity: u32) -> Self; | |||
|
|
|||
| fn expiration(&self) -> Option<u64>; | |||
There was a problem hiding this comment.
should we a setter with_expiration here, like we have for maturity
There was a problem hiding this comment.
Good question. Well other policies are also missing the with_ methods. We can either remove it or add them for all? What do you think?
There was a problem hiding this comment.
with_maturity changes the tx_id so I would like to remove it.
| @@ -1245,3 +1245,80 @@ async fn predicate_configurables_in_blobs() -> Result<()> { | |||
|
|
|||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn predicate_transfer_respects_maturity_and_expiration() -> Result<()> { | |||
There was a problem hiding this comment.
At some point, we should discuss how we want to approach testing for features like this, where we cover various transaction and input types. It feels like the level of granularity here (and in other cases) might be higher than what we actually benefit from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1577
Release notes
Added the
expirationtransaction policy. Now the user can limit until which block height the transaction is valid.Breaking Changes
expiration: Option<u64>field toTxPoliciesstructTransactiontrait methodmaturitynow returnsOption<u64>Transactiontrait methodwith_maturityis removed.Checklist