fix(gas_price_service_v1): ensure that the algo updater is synced to l2 block height #2504
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
acerone85
reviewed
Dec 17, 2024
|
|
||
| // then | ||
| // no panic | ||
| // sleep to allow the service to sync | ||
| tokio::time::sleep(std::time::Duration::from_millis(100)).await; |
There was a problem hiding this comment.
personally I'm not a fan of sleep of sleeps to wait for a condition to happen, but this is orthogonal to the PR.
There was a problem hiding this comment.
Agree, but with tokio time I can accept it since tokio auto-advances time when all futures are pending.
(Reference https://docs.rs/tokio/latest/tokio/time/fn.pause.html)
acerone85
approved these changes
Dec 17, 2024
netrome
approved these changes
Dec 17, 2024
|
|
||
| // then | ||
| // no panic | ||
| // sleep to allow the service to sync | ||
| tokio::time::sleep(std::time::Duration::from_millis(100)).await; |
There was a problem hiding this comment.
Agree, but with tokio time I can accept it since tokio auto-advances time when all futures are pending.
(Reference https://docs.rs/tokio/latest/tokio/time/fn.pause.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Description
We didn't have this check in the
uninitialized_task__init__if_metadata_behind_l2_height_then_synctest, which caused us to miss the duped algo updater.Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]