P2pService: Make max_response_size in PostcardCodec a u64 #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acerone85
requested review from
xgreenx,
Dentosal and
MitchTurner
as code owners
17 tasks
xgreenx
reviewed
Dec 13, 2024
| @@ -14,7 +14,7 @@ use std::{ | |||
| pub struct PostcardCodec; | |||
|
|
|||
| impl RequestResponseMessageHandler<PostcardCodec> { | |||
| pub fn new(max_block_size: usize) -> Self { | |||
| pub fn new(max_block_size: u64) -> Self { | |||
There was a problem hiding this comment.
We can use NonZeroU64, then we don't need check below=)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Closes #2459
Description
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]