Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXP BSP LF6.6.3-1.1.0: Update SCR and EULA #1778

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

MrCry0
Copy link
Contributor

@MrCry0 MrCry0 commented Mar 30, 2024

This PR is a part of solution to #1777

@MrCry0 MrCry0 requested review from otavio and a team March 30, 2024 13:49
Copy link
Member

@angolini angolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the PR, and to start the new upstream.

I only want to emphasize the 6.6.3-1.1.0 release is based on Nanbield, so we may want to finish the upstream before scarthgap, perhaps?

@@ -147,7 +176,7 @@ License File: LICENSE
Package Category: BSP
Type of Content: source
Description and comments: BSP libraries
Release Location: https://github.com/nxp-imx/imx-lib -b lf-6.1.55_2.2.0
Release Location: https://github.com/nxp-imx/imx-lib -b master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thochstein

I'm only double checking if "master" is ok here

Here [1], we have "lf-6.6.3_1.0.0" instead.
[1] https://github.com/nxp-imx/meta-imx/blob/nanbield-6.6.3-1.0.0/meta-imx-bsp/recipes-bsp/imx-lib/imx-lib_git.bbappend

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the SCR is wrong. I will follow up internally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angolini thanks for notice this, I'm rechecking all "master" cases in SCR and fixing them properly. It seems a bug in meta--imx.

@otavio otavio requested a review from thochstein April 1, 2024 14:04
Copy link
Contributor

@thochstein thochstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but you need to update fsl-eula-unpack.bbclass as well.

@MrCry0 MrCry0 marked this pull request as draft April 1, 2024 17:41
@MrCry0 MrCry0 force-pushed the master-scr-eula-6.6.3 branch from c3ca041 to 7e0c97f Compare April 1, 2024 18:11
MrCry0 added 2 commits April 1, 2024 21:48
This version is used in NXP BSP LF6.6.3-1.0.0.

Signed-off-by: Oleksandr Suvorov <[email protected]>
Fixed wrong master branches for:
- imx-lib -b lf-6.6.3_1.0.0
- imx-firmware -b lf-6.6.3_1.0.0
- imx-alsa-plugins -b MM_04.08.03_2312_L6.6.y

Signed-off-by: Oleksandr Suvorov <[email protected]>
@MrCry0 MrCry0 force-pushed the master-scr-eula-6.6.3 branch from 7e0c97f to 910dc45 Compare April 1, 2024 18:48
@MrCry0
Copy link
Contributor Author

MrCry0 commented Apr 1, 2024

Looks good but you need to update fsl-eula-unpack.bbclass as well.

@thochstein Fixed, thanks!

@MrCry0 MrCry0 marked this pull request as ready for review April 1, 2024 18:49
@otavio otavio requested a review from thochstein April 1, 2024 18:52
@otavio otavio merged commit 19d33d8 into Freescale:master Apr 1, 2024
@MrCry0 MrCry0 deleted the master-scr-eula-6.6.3 branch April 21, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants