imx-mcore-demos: Fix install for multilib Replace base_libdir with nonarch_base_libdir
#1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thochstein
reviewed
Nov 2, 2023
| @@ -57,6 +57,6 @@ addtask deploy after do_install | |||
|
|
|||
| PACKAGE_ARCH = "${MACHINE_SOCARCH}" | |||
|
|
|||
| FILES:${PN} = "${nonarch_base_libdir}/firmware" | |||
| FILES:${PN} = "${baselib}/firmware" | |||
There was a problem hiding this comment.
It's do_install that needs to be fixed, installing to nonarch_base_libdir instead.
There was a problem hiding this comment.
Thank you @thochstein, fixed that
thochstein
suggested changes
Nov 2, 2023
quaresmajose
reviewed
Nov 3, 2023
| # install elf format binary to /lib/firmware | ||
| install -d ${D}${base_libdir}/firmware | ||
| install -m 0644 ${S}/*.elf ${D}${base_libdir}/firmware | ||
| # install elf format binary to /usr/lib/firmware |
There was a problem hiding this comment.
It will be better to drop this line as it depends on multilib or usermerge
Replace `base_libdir` with `nonarch_base_libdir` Signed-off-by: Valentin Jec <[email protected]>
otavio
approved these changes
Nov 3, 2023
valijec
changed the title
nonarch_base_libdir with baselib to avoid packaging errorbase_libdir with nonarch_base_libdir
thochstein
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multilib configuration there is a build break at packaging step