Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump linux-imx to lf-6.1.36_2.1.0 #1667

Merged
merged 4 commits into from
Oct 18, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conf/machine/imx8mp-lpddr4-evk.conf
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ KERNEL_DEVICETREE:append:use-nxp-bsp = " \
freescale/imx8mp-evk-rpmsg.dtb \
freescale/imx8mp-evk-rpmsg-lpv.dtb \
freescale/imx8mp-evk-sof-wm8960.dtb \
freescale/imx8mp-evk-sof-pdm.dtb \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@otavio, @thochstein two questions here.

I expected to find KERNEL_DEVICETREE for imx8mp-ddr4-evk.conf and imx8mp-lpddr4-evk.conf in the imx8mp-evk.inc file. Is there a reason? For me it looks like the .inc file is a better place.

Should we be using ${KERNEL_DEVICETREE_BASENAME} instead?

I don´t know those boards so I'm not sure about this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't support both board flavors with the same devicetrees?

Using KERNEL_DEVICETREE_BASENAME is a good idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. The dtb filenames are "basic", that's why I guessed it would go to the .inc file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you could check the kernel to see.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you could check the kernel to see.

freescale/imx8mp-evk-spdif-lb.dtb \
freescale/imx8mp-evk-usdhc1-m2.dtb \
freescale/imx8mp-evk-8mic-swpdm.dtb \
Expand Down