Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weston not starting under sysvinit #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix weston not starting under sysvinit #126

wants to merge 1 commit into from

Conversation

vishwamartur
Copy link
Contributor

Related to #123

Modify configuration files to support sysvinit for weston.

  • conf/distro/fsl-wayland.conf

    • Set INIT_MANAGER to "sysvinit" when sysvinit is used.
    • Add a conditional check for sysvinit in the INIT_MANAGER setting.

  • conf/distro/fslc-wayland.conf

    • Set INIT_MANAGER to "sysvinit" when sysvinit is used.
    • Add a conditional check for sysvinit in the INIT_MANAGER setting.

  • recipes-fsl/images/fsl-image-machine-test.bb

    • Include necessary sysvinit configurations for weston.
    • Add a conditional check for sysvinit in the CORE_IMAGE_EXTRA_INSTALL setting.

  • recipes-fsl/images/fsl-image-multimedia.bb

    • Include necessary sysvinit configurations for weston.
    • Add a conditional check for sysvinit in the CORE_IMAGE_EXTRA_INSTALL setting.

@vishwamartur
Fix weston not starting under sysvinit
e444695 
Related to Freescale#123

Modify configuration files to support sysvinit for weston.

* **conf/distro/fsl-wayland.conf**
  - Set `INIT_MANAGER` to "sysvinit" when sysvinit is used.
  - Add a conditional check for sysvinit in the `INIT_MANAGER` setting.

* **conf/distro/fslc-wayland.conf**
  - Set `INIT_MANAGER` to "sysvinit" when sysvinit is used.
  - Add a conditional check for sysvinit in the `INIT_MANAGER` setting.

* **recipes-fsl/images/fsl-image-machine-test.bb**
  - Include necessary sysvinit configurations for weston.
  - Add a conditional check for sysvinit in the `CORE_IMAGE_EXTRA_INSTALL` setting.

* **recipes-fsl/images/fsl-image-multimedia.bb**
  - Include necessary sysvinit configurations for weston.
  - Add a conditional check for sysvinit in the `CORE_IMAGE_EXTRA_INSTALL` setting.
thochstein
thochstein reviewed Nov 5, 2024
View reviewed changes
recipes-fsl/images/fsl-image-machine-test.bb
@@ -28,4 +28,6 @@ CORE_IMAGE_EXTRA_INSTALL += " \
'weston weston-init', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'x11 wayland', \
'weston-xwayland xterm', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', \
'weston-sysvinit', '', d)} \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is weston-sysvinit provided? I can't find it.

thochstein
thochstein reviewed Nov 5, 2024
View reviewed changes
conf/distro/fsl-wayland.conf
@@ -6,7 +6,7 @@ DISTRO = "fsl-wayland"
DISTRO_NAME = "FSL Wayland"

# Define Init System
INIT_MANAGER = "systemd"
INIT_MANAGER = "${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', 'sysvinit', 'systemd', d)}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you should just set INIT_MANAGER directly to change to sysvinit. Then, the poky conf files will setup many variables, including DISTRO_FEATURES. See https://docs.yoctoproject.org/dev/singleindex.html#term-INIT_MANAGER.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, in this case, there should be a ?= and let user to override that.

Another thing, think more about that, is we can set that in the base configuration file, so we avoiding repeating that.

@vishwamartur
Copy link
Contributor Author

Thank you for the feedback, @thochstein and @otavio.

@thochstein, regarding your question about where weston-sysvinit is provided, I included it as part of the conditional checks within the CORE_IMAGE_EXTRA_INSTALL settings in the fsl-image-machine-test.bb and fsl-image-multimedia.bb recipes. If it’s not defined in the current recipes, I’ll ensure to add the necessary recipe for weston-sysvinit to make it available.

As for the INIT_MANAGER setting, I appreciate your suggestion to directly set it to sysvinit. I will modify the configuration to use INIT_MANAGER ?= "sysvinit" to allow users to override it as needed, as @otavio suggested. This should help avoid repetition and ensure that the configuration is clean and maintainable.

I’ll make these adjustments and update the pull request shortly. Thanks again for your insights!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thochstein thochstein thochstein left review comments

@otavio otavio otavio approved these changes

@angolini angolini Awaiting requested review from angolini

@junzhuimx junzhuimx Awaiting requested review from junzhuimx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishwamartur @otavio @thochstein