[static-analysis] Fix static analysis level 2 errors. #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swashata
reviewed
Dec 31, 2023
bahiirwa
force-pushed
the
feature/static-analysis-level-1-fixes
branch
from
1b17dbe
to
2419e91
Compare
fajardoleo
requested changes
Feb 12, 2024
bahiirwa
force-pushed
the
feature/static-analysis-level-1-fixes
branch
2 times, most recently
from
bfd1c8d
to
48aaba0
Compare
fajardoleo
approved these changes
Apr 16, 2024
swashata
requested changes
May 13, 2024
| @@ -14323,6 +14320,7 @@ private function get_parent_and_addons_installs_info() { | |||
| ) | |||
| ); | |||
|
|
|||
| $installed_addons_ids_map = array_flip( $installed_addons_ids ); | |||
There was a problem hiding this comment.
@swashata Yes, it is. Caught it while doing the checks. Should we push this in another PR?
includes/class-freemius.php
Outdated
| @@ -20061,7 +20057,7 @@ private function _store_licenses( $store = true, $module_id = false, $licenses = | |||
| } | |||
| } | |||
|
|
|||
| if ( ! empty( $new_user_licenses_map ) ) { | |||
| if ( count( $new_user_licenses_map ) > 0 ) { | |||
There was a problem hiding this comment.
Is this something PHPStan is forcing us to do?
bahiirwa
force-pushed
the
feature/static-analysis-level-1-fixes
branch
2 times, most recently
from
6ee7406
to
fe76177
Compare
bahiirwa
changed the title
bahiirwa
force-pushed
the
feature/static-analysis-level-1-fixes
branch
3 times, most recently
from
e47c49a
to
ae44f1c
Compare
bahiirwa
force-pushed
the
feature/static-analysis-level-1-fixes
branch
2 times, most recently
from
5999f7f
to
2bef074
Compare
…. 2 parameters given but 1 required.
…iables are misnamed in code that follows.
… property object.
bahiirwa
force-pushed
the
feature/static-analysis-level-1-fixes
branch
from
2bef074
to
aff954f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
count()You can advise on that. The goal was to maintain the checks in place and not modify functionality.