Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[github-actions] [static-analysis] [CI] Add static analysis & phpcs tools for supported PHP versions 5.6-8.0+. #646

Merged
merged 2 commits into from
Jul 19, 2023
Merged

[github-actions] [static-analysis] [CI] Add static analysis & phpcs tools for supported PHP versions 5.6-8.0+. #646

merged 2 commits into from
Jul 19, 2023

Conversation

bahiirwa
Copy link
Contributor

  • Add static analysis and phpcs tools for supported PHP versions 5.6-8.0+.
  • Fix level 0 issues & add exclusions for false positives.
  • Github actions for Continuous Integration.

@bahiirwa bahiirwa requested a review from swashata July 19, 2023 11:12
swashata
swashata approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@swashata swashata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

swashata
swashata requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@swashata swashata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bahiirwa Please rebase this on develop and bring the PR to develop.

@bahiirwa bahiirwa changed the base branch from master to develop July 19, 2023 11:27
swashata
swashata approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@swashata swashata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it is all good now.

@swashata swashata merged commit 55045c9 into develop Jul 19, 2023
4 checks passed
@swashata swashata deleted the feature/php-static-analysis branch July 19, 2023 11:33
@bahiirwa bahiirwa mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashata swashata swashata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bahiirwa @swashata