Fix: avoid logging attempt when table does not exist

includes/class-fs-logger.php

@@ -11,6 +11,10 @@
  }
 
  class FS_Logger {
+ /**
+ * @var bool
+ */
+ public static $ON = false;
  private $_id;
  private $_on = false;
  private $_echo = false;
@@ -32,6 +36,9 @@ class FS_Logger {
  */
  private static $_abspathLength;
 
+ /**
+ * @var FS_Logger[] $LOGGERS
+ */
  private static $LOGGERS = array();
  private static $LOG = array();
  private static $CNT = 0;
@@ -112,7 +119,7 @@ private static function hook_footer() {
  }
 
  function is_on() {
- return $this->_on;
+ return $this->_on && self::$ON;
  }
 
  function on() {
@@ -125,6 +132,15 @@ function on() {
  self::hook_footer();
  }
 
+ /**
+ * Turn off instance
+ *
+ * @return void
+ */
+ public function off() {
+ $this->_on = false;
+ error_log( $this->get_id() . ' IS NOW ' . $this->_on );
+ }
  function echo_on() {
  $this->on();
 
@@ -240,6 +256,9 @@ function api_error( $api_result, $wrapper = false ) {
  }
 
  function entrance( $message = '', $wrapper = false ) {
+ if ( ! $this->is_on() ) {
+ return;
+ }
  $msg = 'Entrance' . ( empty( $message ) ? '' : ' > ' ) . $message;
 
  $this->_log( $msg, 'log', $wrapper );
@@ -353,9 +372,21 @@ public static function _set_storage_logging( $is_on = true ) {
  * Drop logging table.
  */
  $result = $wpdb->query( "DROP TABLE IF EXISTS $table;" );
+ /**
+ * Since logging table does not exist anymore, we need to turn off all instances
+ */
+ foreach ( self::$LOGGERS as $logger ) {
+ $logger->off();
+ }
+ /**
+ * Also, we delete all references and turn off global logging
+ */
+ self::$LOGGERS = [];
+ self::$ON = false;
  }
 
  if ( false !== $result ) {
+ self::$ON = (bool) $is_on;
  update_option( 'fs_storage_logger', ( $is_on ? 1 : 0 ) );
  }
 

includes/managers/class-fs-debug-manager.php

@@ -189,6 +189,10 @@ static function _get_debug_log() {
  return;
  }
 
+ if (!FS_Logger::$ON) {
+ return;
+ }
+
  $limit = min( ! empty( $_POST['limit'] ) ? absint( $_POST['limit'] ) : 200, 200 );
  $offset = min( ! empty( $_POST['offset'] ) ? absint( $_POST['offset'] ) : 200, 200 );