Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure correct message length after parsing #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure correct message length after parsing #193

wants to merge 1 commit into from

Conversation

fabien-gigante
Copy link

@fabien-gigante fabien-gigante commented Dec 29, 2020 •
edited

After parsing the message length was not properly set in multiple cases.
Which doesn't allow for instance to use those messages as is with send(). Typical usage below.

  LocalMIDI.setHandleMessage([](const midi::Message<128>& msg) { RemoteMIDI.send(msg); });
  RemoteMIDI.setHandleMessage([](const midi::Message<128>& msg) { LocalMIDI.send(msg); });

@fabien-gigante
Ensure correct message length after parsing
f094ece 
After parsing the message length was still zero in multiple cases.
Which doesn't allow for instance to use those messages as is with send()
@franky47 franky47 added this to the 5.0.3 milestone Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabien-gigante @franky47