Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Call Type Button Options #351

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding Call Type Button Options #351

wants to merge 2 commits into from

Conversation

athenp
Copy link
Contributor

@athenp athenp commented Dec 2, 2019

Added the ability to remove any number of the three call types (audio, video, screenshare) from the callView. Options are passed through threadCallStart.

@athenp athenp requested a review from mayfield December 2, 2019 22:39
mayfield
mayfield requested changes Dec 2, 2019
View reviewed changes
Copy link
Member

@mayfield mayfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're going to hate me, but I'd like to see this done a different way.

I think because those are static view options they should go into the constructor for the call view as viewOptions. Let's do a quick call to walk through what I mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayfield mayfield mayfield requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athenp @mayfield