Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize react example code in docs #2867

Merged
merged 2 commits into from
May 15, 2024
Merged

Modernize react example code in docs #2867

merged 2 commits into from
May 15, 2024

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented May 14, 2024

Convert demos, example code, and gallery code to use Functional React Components instead of Class Components to modernize the examples

Preview for testing: https://victory-git-docs-functional-formidable-labs.vercel.app/open-source/victory/docs

Convert demos, example code, and gallery code to use Functional React Components instead of Class Components to modernize the examples
Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: bb43668

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 6:22pm

Copy link
Contributor

@BrittanyIRL BrittanyIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VIVA TOMATO 🍅

Read through, nice to see the modernized functions. Also clicked around, nothing breaks.

@carbonrobot carbonrobot merged commit 359a99e into main May 15, 2024
6 checks passed
@carbonrobot carbonrobot deleted the docs/functional branch May 15, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants