fix local default textures not loading

Flutterish · Feb 1, 2022 · 96ddf53 · 96ddf53
1 parent 0c262ba
commit 96ddf53
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/osu.Game.Rulesets.RurusettoAddon/API/APIUser.cs b/osu.Game.Rulesets.RurusettoAddon/API/APIUser.cs
@@ -36,11 +36,11 @@ public void RequestDetail ( Action<UserProfile> success, Action? failure = null
 			}
 		}
 
-		public void RequestProfilePicture ( Action<Texture> success, Action<Texture>? failure = null ) {
+		public void RequestProfilePicture ( Action<Texture> success, Action? failure = null ) {
 			void requestDefault () {
 				if ( API != null ) {
 					API.RequestImage( StaticAPIResource.DefaultProfileImage, success, failure: () => {
-						failure?.Invoke( Texture.WhitePixel );
+						failure?.Invoke();
 					} );
 				}
 			}

diff --git a/osu.Game.Rulesets.RurusettoAddon/UI/Info/InfoTab.cs b/osu.Game.Rulesets.RurusettoAddon/UI/Info/InfoTab.cs
@@ -44,9 +44,11 @@ public InfoTab ( APIRuleset ruleset ) {
 		}
 
 		OverlayColourProvider colourProvider;
+		Texture defaultCover;
 		[BackgroundDependencyLoader]
-		private void load ( OverlayColourProvider colourProvider ) {
+		private void load ( OverlayColourProvider colourProvider, GameHost host, TextureStore textures, RurusettoAddonRuleset ruleset ) {
 			this.colourProvider = colourProvider;
+			defaultCover = ruleset.GetTexture( host, textures, TextureNames.DefaultCover );
 		}
 
 		SubpageListingEntry main;
@@ -58,11 +60,6 @@ private void load ( OverlayColourProvider colourProvider ) {
 
 		ILocalisedBindableString contentBindable;
 
-		Texture defaultCover;
-		private void load ( GameHost host, TextureStore textures, RurusettoAddonRuleset ruleset ) {
-			defaultCover = ruleset.GetTexture( host, textures, TextureNames.DefaultCover );
-		}
-
 		protected override void LoadContent () {
 			AddInternal( new Container {
 				RelativeSizeAxes = Axes.X,

diff --git a/osu.Game.Rulesets.RurusettoAddon/UI/Users/DrawableRurusettoUser.cs b/osu.Game.Rulesets.RurusettoAddon/UI/Users/DrawableRurusettoUser.cs
@@ -172,8 +172,6 @@ protected override void LoadComplete () {
 
 			user.RequestProfilePicture( texture => {
 				pfp.Texture = texture;
-			}, fallback => {
-				pfp.Texture = fallback;
 			} );
 		}