Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: change button style of AssetAction buttons too neutral #199

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

crydotsnake
Copy link
Member

@crydotsnake crydotsnake commented Aug 4, 2023

resolves: #198

What I did

See: #198

If the buttons are transparent it makes them a bit hard to see especially if you have a file with a white background, for example. And since the icons themselves already have a white color, it doesent look very nice on a transparent background.

Besides, it simply makes a nicer impression in general in my opinion.
But I am of course open for opinions !

How I did it

Changed the style of the AssetActions buttons from transparent too neutral.

How to verify it

Before

SCR-20230804-ssyq

After

SCR-20230804-srrh

@crydotsnake crydotsnake requested a review from Sebobo August 14, 2023 08:16
Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way you also change their look in the list of the media module. There I intentionally used the transparent versions.

That means you should set the button type as variable here and make it dependent on where it's being used.

@crydotsnake
Copy link
Member Author

crydotsnake commented Aug 18, 2023

I checked it with:

style={viewModeSelection === VIEW_MODES.List ? 'transparent' : 'neutral'}

But it still looks a little bit buggy too me 😕
Peek 2023-08-18 17-44

I'm working on it.

Edit

Nevermind. i forgot too adjust one line.. 🤦🏽

@crydotsnake
Copy link
Member Author

Looks good! 🙂

new-behavior

@crydotsnake crydotsnake requested a review from Sebobo August 18, 2023 15:56
@crydotsnake crydotsnake added the Enhancement Something that should be or will be improved label Aug 21, 2023
@Sebobo
Copy link
Member

Sebobo commented Sep 11, 2023

Thx, will check it asap

@Sebobo
Copy link
Member

Sebobo commented Sep 15, 2023

These examples don't look so good:

Bildschirmfoto 2023-09-15 um 12 53 02 Bildschirmfoto 2023-09-15 um 12 52 25

The buttons in thumbs view should remain transparent without hover.
In the list mode the button position is not fully correct, you can see a little blue gap the the top. Maybe we should change the active and hover color, so there is a highlight on hover visible on the buttons. Do you want to try at a better solution with out color scheme?
We also have the color variants of the primary colors in our brand guide.

Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

@crydotsnake crydotsnake self-assigned this Sep 29, 2023
@crydotsnake
Copy link
Member Author

The buttons in thumbs view should remain transparent without hover.

Hm. Like that? This also doesent look good IMO.. or maybe I have to give it a little time and think about it.

demo.mov

@Sebobo
Copy link
Member

Sebobo commented Oct 17, 2023

No, with your change there were not transparent by default anymore for me. I would prefer if they stay transparent "until" they are hovered.
And in the list view they should still look good when the line is hovered and the background is therefore blue. That was also off like in my screenshot.l.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Something that should be or will be improved
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Discussion: Make Preview Action Buttons "neutral" instead of "transparent"
2 participants