Merge pull request #52 from Flowpack/bugfix/nameCreateFromNodeSubtree…

…CommandCorrectly BUGFIX: Name command method correctly
Flowpack · Jun 5, 2023 · 92d5735 · 92d5735
2 parents 9042e5a + 05a4f70
commit 92d5735
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/Classes/Command/NodeTemplateCommandController.php b/Classes/Command/NodeTemplateCommandController.php
@@ -31,7 +31,7 @@ class NodeTemplateCommandController extends CommandController
      * @param string $workspaceName
      * @return void
      */
-    public function createFromNodeSubtree(string $startingNodeId, string $workspaceName = 'live'): void
+    public function createFromNodeSubtreeCommand(string $startingNodeId, string $workspaceName = 'live'): void
     {
         $subgraph = $this->contentContextFactory->create([
             'workspaceName' => $workspaceName

diff --git a/Classes/NodeTemplateDumper/NodeTemplateDumper.php b/Classes/NodeTemplateDumper/NodeTemplateDumper.php
@@ -42,17 +42,21 @@ public function createNodeTemplateYamlDumpFromSubtree(NodeInterface $startingNod
 
         $template = $this->nodeTemplateFromNodes([$startingNode], $comments);
 
+        $firstEntry = null;
         foreach ($template as $firstEntry) {
             break;
         }
-        assert(isset($firstEntry));
+
+        $properties = $firstEntry['properties'] ?? null;
+        $childNodes = $firstEntry['childNodes'] ?? null;
+
 
         $templateInNodeTypeOptions = [
             $nodeType->getName() => [
                 'options' => [
                     'template' => array_filter([
-                        'properties' => $firstEntry['properties'] ?? null,
-                        'childNodes' => $firstEntry['childNodes'] ?? null,
+                        'properties' => $properties,
+                        'childNodes' => $childNodes
                     ])
                 ]
             ]