TASK: Use PHP 8 features #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebobo
force-pushed
the
task/use-php8-features
branch
from
9f060d7 to
fb81829
Compare
|
@Sebobo Is this ready for review? |
|
Think so |
|
Not really sure about those inject annotations because they lead to non-lazy injections. Is that worth the performance impact |
|
No clue if that matters much, also didn't know the annotation behaves so differently. Can change it back for those cases. |
|
@Sebobo that was not precise from me, What behaves differently is typed properties that are injected because the strict type does not allow lazy injection. The annotation itself is not a problem. |
|
@mficzel adjusted it again |
Benjamin-K
reviewed
Dec 4, 2023
Comment on lines
22
to
24
| /** | ||
| * @Flow\Before("method(Neos\Fusion\Core\Cache\ContentCache->(createUncachedSegment)())") | ||
| */ |
There was a problem hiding this comment.
Could also be rewritten to
#[Flow\Before("method(Neos\Fusion\Core\Cache\ContentCache->createUncachedSegment())")]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #18