Bugfix: Should throw error if indexname is not set #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is common practice to use an ENV variable to set the index name. If it's not present, $name is not empty string, but false.
daniellienert
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Hey @amtee,
According to https://www.php.net/manual/de/function.trim.php, trim never returns false - so your check will never be true. Do I miss somehing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common practice to use an ENV variable to set the index name. If it's not present,It is common practice to use an ENV variable to set the index name. If it's not present,
$nameis not empty string, butfalse.I know this is likely not a bug in the Adaptor itself, maybe let's see this as an enhancement 😄 $name is not empty string, but false.