Merge pull request #33 from abderrahmaneib/abderrahmaneib-patch-1

Fix Issue #19 - Correct output for CallbackFunction and SQLFunction Sniffs
FloeDesignTechnologies · Aug 4, 2019 · b098ae9 · b098ae9
2 parents ea4120b + 5b7358e
commit b098ae9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Security/Sniffs/BadFunctions/CallbackFunctionsSniff.php b/Security/Sniffs/BadFunctions/CallbackFunctionsSniff.php
@@ -45,9 +45,9 @@ public function process(File $phpcsFile, $stackPtr) {
 			$msg = 'Function ' . $tokens[$stackPtr]['content'] . '() that supports callback detected';
              if ($s) {
 				if ($utils::is_token_user_input($tokens[$s])) {
-					$phpcsFile->addError($msg . ' with parameter directly from user input', $stackPtr, 'ErrFringestuff');
+					$phpcsFile->addError($msg . ' with parameter directly from user input', $stackPtr, 'ErrCallbackFunctions');
 				} else {
-					$phpcsFile->addWarning($msg, $stackPtr, 'WarnFringestuff');
+					$phpcsFile->addWarning($msg, $stackPtr, 'WarnCallbackFunctions');
 				}
 			}
 		}

diff --git a/Security/Sniffs/BadFunctions/SQLFunctionsSniff.php b/Security/Sniffs/BadFunctions/SQLFunctionsSniff.php
@@ -38,9 +38,9 @@ public function process(File $phpcsFile, $stackPtr) {
              if ($s) {
 				$msg = 'SQL function ' . $tokens[$stackPtr]['content'] . '() detected with dynamic parameter ';
 				if ($utils::is_token_user_input($tokens[$s])) {
-					$phpcsFile->addError($msg . ' directly from user input', $stackPtr, 'ErrFilesystem');
+					$phpcsFile->addError($msg . ' directly from user input', $stackPtr, 'ErrSQLFunction');
 				} else {
-					$phpcsFile->addWarning($msg, $stackPtr, 'WarnFilesystem');
+					$phpcsFile->addWarning($msg, $stackPtr, 'WarnSQLFunction');
 				}
 			}
 		}