This repository has been archived by the owner on Apr 7, 2024. It is now read-only.
GitHub Integrations Improvements #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… are caught by middleware
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More gracefully handles the GitHub installation workflow for when a user goes through the GitHub integration flow and triggers an "Installation Request" on GitHub. This happens in situations where the requesting user does not have admin privileges in GitHub.
Unfortunately, this
requestflow is not yet well supported by GitHub:https://github.com/orgs/community/discussions/42351
This means that it is not possible to store the installation on the workspace programmatically. Therefore, as a workaround this solution will send an email to me with the installation id. I can then manually authenticate the request and then update the workspace github integration with the
installationIdand set thestatustoinstalled.In the future, this solution should be made programatic if GitHub indeed updates the request callback.