Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: changing tsconfig target and module to es6 with esModuleInterop flag on #523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: changing tsconfig target and module to es6 with esModuleInterop flag on #523

wants to merge 2 commits into from

Conversation

muskeinsingh
Copy link
Contributor

@muskeinsingh muskeinsingh commented Jul 13, 2020 •
edited

  • the library is exported as commonJS which basically does not let the end user avail es6 benefits like tree shaking. hence, moving to target and module as es6
  • moving the require for lodash/debounce as import after the esModuleInterop flag is on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananyachandra14 ananyachandra14 ananyachandra14 approved these changes

@arunreddy10 arunreddy10 arunreddy10 approved these changes

@naqvitalha naqvitalha Awaiting requested review from naqvitalha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@muskeinsingh @ananyachandra14 @arunreddy10