Add revert changes button #818
Conversation
PrographerMan
force-pushed
the
feature-231670-add-revert-changes-button
branch
4 times, most recently
from
8875ead
to
ae0b517
Compare
| @@ -149,6 +149,12 @@ export default FdBaseSheet.extend( | |||
| iconClasses: ' icon-fd-uml-edit icon', | |||
| buttonAction: this.get('umlСorrector').bind(this) | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
я все еще думаю что стоит кнопку перенести в тоол бар
| const revert = () => { | ||
| this.openSheet(this.get('sheetComponentName'), this.get('selectedValue')); | ||
| } | ||
| const currentStageRecords = new A([ |
There was a problem hiding this comment.
мб использовать метод из сервиса который проверяет диаграммы при открытии? https://github.com/Flexberry/ember-flexberry-designer/blob/develop/addon/services/fd-sheet-service.js#L236 и тогда поидее эта логика будет для всех листов работать
PrographerMan
force-pushed
the
feature-231670-add-revert-changes-button
branch
4 times, most recently
from
a0779e7
to
339312d
Compare
| @@ -201,6 +201,10 @@ export default Component.extend(FdReadonlyProjectMixin, FdShareFunctionMixin, { | |||
| }, | |||
|
|
|||
| actions: { | |||
| revertChanges() { | |||
| this.openSheet(this.get('sheetComponentName'), this.get('targetObject.selectedValue.data')) | |||
There was a problem hiding this comment.
А где модальное окно для подтверждения? где вызов метода findUnsavedSheetData для проверки? и ошибки валятся
PrographerMan
force-pushed
the
feature-231670-add-revert-changes-button
branch
2 times, most recently
from
66ac521
to
493fe61
Compare
| @@ -251,6 +251,10 @@ export default FdBaseSheet.extend( | |||
| this.set('selectedValue', undefined); | |||
| }, | |||
|
|
|||
| revertChanges() { | |||
| @@ -135,6 +135,21 @@ export default FdBaseSheet.extend({ | |||
| this.set('selectedValue', undefined); | |||
| }, | |||
|
|
|||
| revertChanges() { | |||
| @@ -4,10 +4,16 @@ | |||
| </div> | |||
| <div class="fd-sheet-header"> | |||
| {{fd-sheets/fd-sheets-tool-bar | |||
| revertChanges=revertChanges | |||
There was a problem hiding this comment.
это все что? зачем? убрать мусор
| @@ -4,10 +4,15 @@ | |||
| </div> | |||
| <div class="fd-sheet-header {{unless isAddMode "fd-sheet-diagram-header"}} {{if _collapseToolbar "fd-toolbar-hidden"}}"> | |||
| {{fd-sheets/fd-sheets-tool-bar | |||
| isDiagramVisible=isDiagramVisible | |||
There was a problem hiding this comment.
На форме диаграммы и модели приложения отличается реализация метода deactivateListItem, поэтому я передаю его параметром в тулбар
| revertChanges() { | ||
| const unsavedData = this.get('fdSheetService').findUnsavedSheetData(this.get('sheetComponentName')); | ||
| const revert = () => { | ||
| this.openSheet(this.get('sheetComponentName'), this.get('selectedValue')) |
There was a problem hiding this comment.
contentSheetValue есть свойство надо использовать его!
selectedValue тут нет!
There was a problem hiding this comment.
не this.openSheet наверное а сервисом надо дергать?
PrographerMan
force-pushed
the
feature-231670-add-revert-changes-button
branch
2 times, most recently
from
4d9b81e
to
10899a6
Compare
PrographerMan
force-pushed
the
feature-231670-add-revert-changes-button
branch
from
10899a6
to
bb31e77
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.