Feature delete and insert #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasNoise
suggested changes
Oct 18, 2019
| var auditOperationInfoList = new List<AuditAdditionalInfo>(); | ||
| var extraProcessingList = new List<DataObject>(); | ||
| GenerateQueriesForUpdateObjects(DeleteQueries, DeleteTables, UpdateQueries, UpdateFirstQueries, UpdateLastQueries, UpdateTables, InsertQueries, InsertTables, TableOperations, QueryOrder, true, AllQueriedObjects, DataObjectCache, extraProcessingList, objects); | ||
| GenerateQueriesForUpdateObjects(DeleteQueries, DeleteTables, UpdateQueries, UpdateFirstQueries, UpdateLastQueries, UpdateTables, InsertQueries, InsertTables, TableOperations, QueryOrder, true, AllQueriedObjects, DataObjectCache, InsertDeleteValue, UpdateClassesValue, extraProcessingList, objects); |
There was a problem hiding this comment.
Предлагаю избавиться от этого бесконечного кол-ва параметров, заменить на объект GenerateQueriesContext, в который и запрятать всё необходимое.
| @@ -268,6 +275,17 @@ public virtual void UpdateObjects(ref DataObject[] objects, DataObjectCache Data | |||
| } | |||
| } | |||
|
|
|||
| if (InsertDeleteValue.Count > 0) | |||
There was a problem hiding this comment.
Аналогичные проверки нужно добавить и для других циклов.
| @@ -4209,6 +4209,8 @@ private bool ContainsKeyINProcessing(Dictionary<TypeKeyPair, bool> processedDict | |||
| /// <param name="checkLoadedProps"> Проверять ли загруженность свойств </param> | |||
| /// <param name="processingObjects"> The processing Objects. </param> | |||
| /// <param name="dataObjectCache"> The Data Object Cache.</param> | |||
| /// <param name="insertDeleteValue"> Обработка случая когда создается новый мастер и старый удаляется, массив мастеров.</param> | |||
| /// <param name="updateClassesValue"> Обработка случая когда создается новый мастер и старый удаляется, массив агрегаторов.</param> | |||
| /// <param name="dobjects"> Для чего генерим запросы </param> | |||
| public virtual void GenerateQueriesForUpdateObjects( | |||
There was a problem hiding this comment.
Тут поменять сигнатуру.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.