Fix gis functions #192
Closed
Fix gis functions #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementation in PostgresDataService.
…LINQ gis-functions prototypes.
bratchikov
reviewed
Jul 20, 2021
| /// <param name="identifier">Identifier in query.</param> | ||
| /// <param name="generateSqlSelectFlag">A flag, indicating that a call is made from GenerateSQLSelect() method.</param> | ||
| /// <returns>Identifier with brackets.</returns> | ||
| protected string PutIdentifierIntoBrackets(string identifier, bool generateSqlSelectFlag) |
There was a problem hiding this comment.
generateSqlSelectFlag - тут нарушена логика уровня ответственности: функция должна быть самодостаточной и ей не нужно знать откуда её вызывают. Если нужен параметр, который как-то меняет поведение функции, то и назови его так, чтобы было понятно что внутри функции "переключится".
| @@ -907,6 +880,7 @@ public override void GenerateSQLRowNumber(LoadingCustomizationStruct customizati | |||
| else if (string.IsNullOrEmpty(orderByExprForPaging)) | |||
| { | |||
| orderByExprForPaging = $"{nl}ORDER BY {SQLWhereLanguageDef.StormMainObjectKey}"; | |||
| query += orderByExprForPaging; | |||
There was a problem hiding this comment.
#191 вернуть как было.
NicholasNoise
suggested changes
Jul 20, 2021
| @@ -907,6 +880,7 @@ public override void GenerateSQLRowNumber(LoadingCustomizationStruct customizati | |||
| else if (string.IsNullOrEmpty(orderByExprForPaging)) | |||
| { | |||
| orderByExprForPaging = $"{nl}ORDER BY {SQLWhereLanguageDef.StormMainObjectKey}"; | |||
| query += orderByExprForPaging; | |||
There was a problem hiding this comment.
#191 вернуть как было.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.