Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of actions/upload-artifact #60

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

piroor
Copy link
Member

@piroor piroor commented Dec 11, 2024

Which issue(s) this PR fixes:

N/A

What this PR does / why we need it:

It is announced that the actions/upload-artifact@v3 will be closing down by 2025-01-30. We need to migrate to v4.
https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes
https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

How to verify the fixed issue:

The steps to verify:

  1. Run the workflow.

Expected result:

The result should have built binaries as artifacts.

@piroor piroor requested a review from kenhys December 11, 2024 02:58
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit a471a43 into master Dec 16, 2024
1 check passed
@kenhys kenhys deleted the bump-version-action-upload-artifact branch December 16, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants