Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize tooltip of buttons #50

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

piroor
Copy link
Member

@piroor piroor commented Jul 25, 2024

Which issue(s) this PR fixes:

N/A

What this PR does / why we need it:

"Move Up", "Move Down" and "Remove" buttons of extra rules are not translated unexpectedly.
This applies localized messages for these buttons as their tooltip text.

How to verify the fixed issue:

Go to the options page and point those buttons.

The steps to verify:

  1. Start Thunderbird.
  2. Install this addon.
  3. Open addons manager.
  4. Click "Options" button for this addon.
  5. Scroll the options page down and point right-top-edge buttons of an extra rule.

Expected result:

The tooltip text is localized.

Describe the obvious situation to verify.

@piroor piroor mentioned this pull request Jul 25, 2024
@piroor piroor requested a review from HashidaTKS July 25, 2024 07:40
@HashidaTKS
Copy link
Contributor

LGTM!

@HashidaTKS HashidaTKS merged commit 3d69d08 into master Jul 25, 2024
2 checks passed
@kenhys kenhys deleted the translate-tooltip-of-buttons branch August 5, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants