Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome.exe (v124) processes keep running on background #1161

Closed
4 tasks done
andtoliom opened this issue Apr 18, 2024 · 17 comments
Closed
4 tasks done

Chrome.exe (v124) processes keep running on background #1161

andtoliom opened this issue Apr 18, 2024 · 17 comments
Labels
help wanted Extra attention is needed needs investigation

Comments

@andtoliom
Copy link

Have you checked our README?

  • I have checked the README

Have you followed our Troubleshooting?

  • I have followed your Troubleshooting

Is there already an issue for your problem?

  • I have checked older issues, open and closed

Have you checked the discussions?

  • I have read the Discussions

Environment

- FlareSolverr version: 3.3.17
- Last working FlareSolverr version: 3.3.16
- Operating system: Windows 11
- Are you using Docker: [yes/no] no
- FlareSolverr User-Agent (see log traces or / endpoint): Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36
- Are you using a VPN: [yes/no] no
- Are you using a Proxy: [yes/no] no
- Are you using Captcha Solver: [yes/no] no
- If using captcha solver, which one:
- URL to test this issue: any

Description

Chrome processes remain active in the background and are never closed, they accumulate until the computer crashes. Flaresolverr is not terminating the processes once it solves the CF challenges. This is happening since the new version of chrome v124. Before it worked perfectly.

Logged Error Messages

No logs messages.

Screenshots

c52b2235cf0692b6b0b16aeea7857abe

@ilike2burnthing
Copy link
Contributor

If you use the v3.3.17 precompiled binaries (with v123 Chromium), does the issue not occur?

@ilike2burnthing ilike2burnthing added the more information needed Further information is requested label Apr 19, 2024
@andtoliom
Copy link
Author

Yes works, but I need to use Chrome v124

@ilike2burnthing
Copy link
Contributor

Why specifically v124?

@andtoliom
Copy link
Author

Why specifically v124?

I use some chrome extensions and I have to edit the source code to load a custom chrome profile

@ilike2burnthing
Copy link
Contributor

Yea, this seems to be specific to Chrome v124, as it affects v3.3.16 too.

You can uninstall Chrome v124 and install v123 instead in the mean time - https://filecr.com/windows/google-chrome/?id=544228864100

@andtoliom
Copy link
Author

Yea, this seems to be specific to Chrome v124, as it affects v3.3.16 too.

You can uninstall Chrome v124 and install v123 instead in the mean time - https://filecr.com/windows/google-chrome/?id=544228864100

Thank you! I will work with v123 till there is a solution for new Chrome versions

@ilike2burnthing
Copy link
Contributor

Alternatively, build your own binaries, which will use Chromium v123:

python src/build_package.py

Then you can reinstall Chrome normally, so you're not stuck on v123.

@ilike2burnthing ilike2burnthing changed the title Chrome.exe processes keep running on background Chrome.exe (v124) processes keep running on background Apr 23, 2024
@ilike2burnthing ilike2burnthing added help wanted Extra attention is needed needs investigation and removed more information needed Further information is requested labels Apr 23, 2024
@asulwer
Copy link

asulwer commented May 13, 2024

chrome v124+ is effected. v126 has the same issue

@asulwer

This comment was marked as off-topic.

@ilike2burnthing
Copy link
Contributor

Aaron, stop being confrontational for no reason, it's getting boring.

@asulwer

This comment was marked as spam.

@RileyXX
Copy link

RileyXX commented May 19, 2024

I'm having this issue as well. Took me a while to track it down to Flaresolverr that was causing it. It's using a lot of resources and generally slowing down my computer just running in the background. I was gaming and getting insane lag and stuttering as well as packet loss and desyc, opened task manager to find chrome process hogging up tons of resources. I just used task manager to end the process but finally couple weeks later I took some time to look into it and discovered it was happening after flaresolverr started running.

Is flaresolverr using chromedriver? If so I had this issue as well where chromedriver was not exiting properly when calling driver.quit() in one of my chromedriver projects. I had to use driver.close() and then call driver.quit() in order to prevent background processes from continuing to run when using chromedriver. This was a new issue that I discovered with recent chrome versions. I wonder if this is what's happening with flaresolverr?

05-19-2024_604

@RileyXX
Copy link

RileyXX commented May 19, 2024

After looking into flaresolver code I can confirm the issue I was talking in my above comment.

https://github.com/search?type=code&auto_enroll=true&q=repo%3AFlareSolverr%2FFlareSolverr+driver.quit

As you can see driver.quit() is being called without driver.close() before it thus causing the chrome background processes to continue to run. I will run a test shortly and see if adding driver.close() fixes it.

@RileyXX
Copy link

RileyXX commented May 19, 2024

After running a test for around 10 minutes after adding driver.close() before driver.quit() the chrome process is still running. Adding driver.close() solved this issue in my other chromedriver project on recent chrome versions so it's odd that it's not working here.

Is flaresolverr intentionally keeping a chrome window open indefinitely in the background?

@asulwer

This comment was marked as spam.

@ilike2burnthing
Copy link
Contributor

5a2c616 working well for me.

v3.3.18

@RileyXX
Copy link

RileyXX commented May 20, 2024

Looks like when I attempted to test it earlier I forgot to turn off my auto updating script and it undid my changes.

Can confirm with the addition of driver.close() the fix does seem to be working for me as well. Very cool! Thanks for the implementation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs investigation
Projects
None yet
Development

No branches or pull requests

4 participants