feat: Add metadata fields to core entities (API) #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3315 +/- ##
==========================================
+ Coverage 95.99% 96.00% +0.01%
==========================================
Files 1135 1135
Lines 36185 36361 +176
==========================================
+ Hits 34735 34909 +174
- Misses 1450 1452 +2 ☔ View full report in Codecov by Sentry. |
5 tasks
matthewelwell
requested changes
Feb 12, 2024
| @@ -2878,7 +3011,7 @@ def test_feature_list_last_modified_values( | |||
| Feature.objects.create(name=f"feature_{i}", project=project) | |||
|
|
|||
| # When | |||
| with django_assert_num_queries(16): # TODO: reduce this number of queries! | |||
| with django_assert_num_queries(19): # TODO: reduce this number of queries! | |||
There was a problem hiding this comment.
What are the extra queries we're adding here, and have we confirmed that we don't have any N+1 issues?
There was a problem hiding this comment.
You're right, I found an N+1 problem. I've fixed it by adding metadata to the prefetch_related used in the queryset.
matthewelwell
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
FE changes:
BE changes:
How did you test this code?
Tests added