Fix false positives of "missing entries for record X" error during index validation #7695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dex validation Cases of false positives: 1. When a deleted record version is committed and has a backversion. The existence of an index entry is not required for such version chain because it is all garbage since a transaction is committed. 2. When a deleted record version is not committed and has a backversion which is also not committed. This can happen when a record is inserted and deleted in the same transaction.
|
Case 2 should not ever happen. update_in_place() and delete_in_place() make sure that there is no uncommitted backversions. Oops, I'm sorry, I missed that this PR is for v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cases of false positives: