Fix invalid conversion in src/common/unicode_util.cpp #7679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UChar declared as char16_t? It is not what Firebird sources could expect. |
th1722
changed the title
I found this error when I built Firebird as part of LibreOffice.
[...]
> workdir/UnpackedTarball/firebird/src/common/unicode_util.cpp:1381:48:
> error: invalid conversion from 'UChar* {aka char16_t*}' to
> 'const short unsigned int*' [-fpermissive]
> const Array<USHORT> str(strChars, prefixLen);
> ^
[...]
Use the reinterpret_cast operator to avoid this error.
No, UChar is declared as unsigned char in LibreOffice. |
|
Quoted error text has different opinion. |
|
On 7/17/23 05:55, th1722 wrote:
UChar declared as char16_t? It is not what Firebird sources could
expect.
No, UChar is declared as unsigned char in LibreOffice.
Do not know for LibreOffice, but thi particular UChar is ICU-specific.
***@***.*** - do not mix with UCHAR in firebird)
And appears it's expected to be 16-bit entity (something like unsigned
short). No idea how is char16_t defined in your case, may be you've
tried to change ICU version for the build?
PS.Sorry for late answer, was at vacations.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this error when I built Firebird as part of LibreOffice.
[...]
Use the reinterpret_cast operator to avoid this error.