Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosette provisioners #283

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Rosette provisioners #283

wants to merge 13 commits into from

Conversation

dbelev
Copy link
Contributor

@dbelev dbelev commented Apr 26, 2022

Description

What

Please be specific and try to describe your thought process. State the obvious, since this might be the first time the reviewer is looking at the code

Why

Copy (if there is one) the text of the original Trello/JIRA ticket in here, with a link back to it for the curious.

Anything, in particular, you'd like to highlight to reviewers

Mention here sections of code which you would like reviewers to pay extra attention to .E.g

Would appreciate a second pair of eyes on the test
I am not quite sure how this bit works
Is there a better library for doing x

Scope and particulars of this PR (Please tick all that apply)

  • Tech hygiene (dependency updating & other tech debt)
  • Bug fix
  • Feature
  • Documentation
  • Breaking change
  • Minor change (e.g. fixing a typo, adding config)

This Pull Request follows the rules described in our Pull Requests Guide

@dbelev dbelev requested a review from a team as a code owner April 26, 2022 12:26
@dbelev dbelev force-pushed the upp-rosette-provisioner branch from 30d6097 to a2559b9 Compare June 8, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant