-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook into Random API #216
Open
KnutAM
wants to merge
9
commits into
Ferrite-FEM:master
Choose a base branch
from
KnutAM:kam/random
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hook into Random API #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
==========================================
- Coverage 96.91% 96.77% -0.14%
==========================================
Files 17 17
Lines 1490 1521 +31
==========================================
+ Hits 1444 1472 +28
- Misses 46 49 +3 ☔ View full report in Codecov by Sentry. |
Ready for review @fredrikekre or @KristofferC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Hooking into the Random API I replaced the
Base.rand(Type{<:AbstractTensor})
byBase.rand(rng::AbstractRNG, ::SamplerType{<:AbstractTensor})
, which has the advantage of supportingrand(MersenneTwister(1), Tensor{2,3})
rand!(::Array{<:AbstractTensor})
.rand(Vec{2}, 2)
(However, specific overload is added to get, e.g.Vector{Vec{2,Float64}}
in this case instead ofVector{Vec{2}}
.)rand(MersenneTwister(2), Vec{2}, 2)
AFAIU the same API doesn't work for
randn
, so this is kept as is.Julia 1.6: For some reason, the type for
apply_all
withf(i) = rand(rng, T)
(whereT<:Number
) is not typestable on julia 1.6, but works at least on 1.8 and later. Old implementation is therefore kept to have fast performance for e.g.rand(Tensor{2,3})
, but the new functionality in the list above is slow (but typestable output via typeassert) on julia 1.6.