Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version string formatting #298

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

ferki
Copy link
Contributor

@ferki ferki commented May 11, 2024

This is an attempt to fix #297 by using git to retrieve the git commit hash only if the source directory looks like a git repository.

Please review and merge, or let me know how to improve it.

Use git to retrieve the git commit hash only if the source directory
looks like a git repository.
@FedeDP
Copy link
Owner

FedeDP commented May 12, 2024

Thank you very much, lgtm!

@FedeDP FedeDP merged commit a4d4762 into FedeDP:master May 12, 2024
3 checks passed
@ferki ferki deleted the fix_version_strings branch May 12, 2024 15:03
@ferki
Copy link
Contributor Author

ferki commented May 12, 2024

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] misformatted version string when installing from the release tarballs
2 participants