Add @JsonKey annotation.
#179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This annotation will be used like `@JsonValue` but only when serializing Map keys. See jackson-databind/#2871
| * Boolean argument is only used so that sub-classes can "disable" | ||
| * annotation if necessary. | ||
| *<p> | ||
| * NOTE: when use for Java <code>enum</code>s, one additional feature is |
There was a problem hiding this comment.
Probably needs to be removed for now
| * to define mapping, but can not be done in general for POJO types; as such, | ||
| * this is not used for POJO deserialization. | ||
| * | ||
| * @see JsonCreator |
There was a problem hiding this comment.
Not sure @JsonCreator handling would be yet supported either.
|
Aside from javadoc comments (which I can tweak too), looks good. I don't think I have CLA yet from you? If so, it's here: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and usual way is to print, fill & sign, scan/photo, email to |
|
Indeed's signed a corporate CLA, should be covered. |
This stuff was copied from JsonValue and isn't correct here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This annotation will be used like
@JsonValuebut only whenserializing Map keys.
See jackson-databind/#2871