Permission normalisation #534
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FasterSpeeding
changed the title
FasterSpeeding
commented
Oct 31, 2022
| | hikari.Permissions.USE_EXTERNAL_STICKERS | ||
| | hikari.Permissions.CREATE_PUBLIC_THREADS | ||
| | hikari.Permissions.MODERATE_MEMBERS | ||
| | ~_CHANNEL_SEND_PERMS |
There was a problem hiding this comment.
is this the best way to do this? (| ~)
FasterSpeeding
commented
Nov 1, 2022
| hikari.ChannelType.GUILD_PRIVATE_THREAD, | ||
| ) | ||
| ) | ||
| _MOVABLE_CHANNEL_TYPES = frozenset( |
There was a problem hiding this comment.
Better name and document what all these constants are
FasterSpeeding
force-pushed
the
task/implicit-perm-denies
branch
from
798e9ac to
bcd6f7d
Compare
FasterSpeeding
force-pushed
the
task/implicit-perm-denies
branch
2 times, most recently
from
f1dff5b to
0d2067f
Compare
|
FasterSpeeding
force-pushed
the
task/implicit-perm-denies
branch
3 times, most recently
from
7afadb1 to
6f8ff0f
Compare
FasterSpeeding
force-pushed
the
task/implicit-perm-denies
branch
from
6f8ff0f to
ad0c43e
Compare
FasterSpeeding
force-pushed
the
task/implicit-perm-denies
branch
from
ad0c43e to
0b03ea0
Compare
FasterSpeeding
force-pushed
the
task/implicit-perm-denies
branch
from
0b03ea0 to
e20c4f5
Compare
FasterSpeeding
force-pushed
the
task/implicit-perm-denies
branch
from
e20c4f5 to
94e0ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
noxand all the pipelines have passed.Related issues