Substitution in spanish now works (didn't before) #1318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
|
Link to python script |
3 tasks
|
Okay, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix(es):
Some substitutions didn't work in Spanish. I suspect they might not work in more languages, I made a quick python script that suggests that more than 500 entries would need updating. I think that it's possible to do this automatically, by replacing the "%" sign with a "$1 in every message which key doesn't contain "option" (as the options page ones need the "%" for input places and such), but I don't really want to make a possibly breaking change to so many languages. I'll upload the script I made to a gist for if someone want's to take a look at it.