Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance: remove unstable debugging from layout generation #1223

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

DSCaskey
Copy link
Contributor

This PR removes the unused debugging code from generating layouts. Since it's unstable it's been commented out at least since forking, and is basically obsolete.

closes issue #1222

Copy link

what-the-diff bot commented Nov 24, 2024

🌟 PR Summary

Every iteration makes our system stronger and smarter. This time, we removed unnecessary complexity and kept our code cleaner and sharper. Let's dive into it! 🎉

  • Removed Debugging Code 🧹💻
    We decided to discard the entire set of debugging options available in some files. This action is a step toward optimizing our codebase by removing sections that are termed 'no longer needed'!

  • Cleaned Up Constructor Initialization 👗🎨
    We wanted our constructor initialization to look clean and be easily understood. We refined the 'VPosition' constructor initialization list in the vposition.cpp file. It's like decluttering a room!

  • Removed Frame Variable Initialization in VLayoutPaperData 🚫🖼️
    We took away the initialization of the 'frame' member variable from the constructors of a class called VLayoutPaperData. This means we're dropping some baggage that we no longer need!

  • Updated Functionality Related to Pieces Arrangement 🎲🔄
    We've reworked on a method called arrangePiece to remove any interaction with the 'frame' variable. This change reflects our quest to make our code more straightforward and efficient!

  • Simplified Debug Drawing 📏✍️
    Debug drawing methods like 'DrawDebug', have been deleted indicating a transition from visual debugging. It implies that we're following a simplified and more efficient approach!

  • Header File Format Consistency 📑💫
    We've harmonized the format of the header comments in the vposition.h and vposition.cpp files because mistakes were so 5 minutes ago! 😉

Exciting times ahead! Keep going, folks! 🚀

Copy link
Collaborator

@slspencer slspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work. As always, please add comments.

@DSCaskey
Copy link
Contributor Author

Not sure what I'm supposed to be commenting? Nothing new was added. The only intent was to take 10 minutes and clean out some useless code I came across.

@DSCaskey
Copy link
Contributor Author

I'm now in the process of comprehending what the handful of layout files are doing so I can comment them, and along way cleaning up some more.

@DSCaskey DSCaskey marked this pull request as draft November 24, 2024 23:08
@DSCaskey DSCaskey marked this pull request as ready for review December 15, 2024 20:12
@slspencer slspencer merged commit df7f689 into develop Dec 17, 2024
10 checks passed
@slspencer slspencer deleted the remove-obsolete-debugging branch December 17, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maintenance: The layout debugging is unstable and obsolete
2 participants