fix fx dialog positioning

FashionFreedom · Nov 26, 2024 · 410a4bf · 410a4bf
1 parent ec1a058
commit 410a4bf
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 22 deletions.
diff --git a/src/libs/vtools/dialogs/support/edit_formula_dialog.cpp b/src/libs/vtools/dialogs/support/edit_formula_dialog.cpp
@@ -120,6 +120,19 @@ EditFormulaDialog::EditFormulaDialog(const VContainer *data, const quint32 &tool
     ui->setupUi(this);
     setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
 
+    // Resize the dialog based on last saved size.
+    const QSize size = qApp->Settings()->GetFormulaWizardDialogSize();
+    if (!size.isEmpty())
+    {
+        // Block signals to prevent a resize event that will only save the size again. 
+        blockSignals(true);
+        resize(size);
+        blockSignals(false);
+    }
+
+    // Set the position that the dialog opens based on user preference.
+    setDialogPosition();
+
     initializeVariables();
     initializeFormulaUi(ui);
     ui->plainTextEditFormula->installEventFilter(this);
@@ -462,42 +475,22 @@ void EditFormulaDialog::closeEvent(QCloseEvent *event)
     DialogTool::closeEvent(event);
 }
 
-//---------------------------------------------------------------------------------------------------------------------
 void EditFormulaDialog::showEvent(QShowEvent *event)
 {
     QDialog::showEvent(event);
     if (event->spontaneous())
     {
         return;
     }
-
-    if (isInitialized)
-    {
-        return;
-    }
-    // do your init stuff here
-
-    const QSize size = qApp->Settings()->GetFormulaWizardDialogSize();
-    if (!size.isEmpty())
-    {
-        resize(size);
-    }
-
-    // Set the position that the dialog opens based on user preference.
-    setDialogPosition();
-
-    isInitialized = true;//first show windows are held
 }
 
 //---------------------------------------------------------------------------------------------------------------------
 void EditFormulaDialog::resizeEvent(QResizeEvent *event)
 {
     // remember the size for the next time this dialog is opened, but only
     // if widget was already initialized.
-    if (isInitialized)
-    {
-        qApp->Settings()->SetFormulaWizardDialogSize(size());
-    }
+    qApp->Settings()->SetFormulaWizardDialogSize(size());
+
     DialogTool::resizeEvent(event);
 }
 

diff --git a/src/libs/vtools/dialogs/support/edit_formula_dialog.ui b/src/libs/vtools/dialogs/support/edit_formula_dialog.ui
@@ -38,6 +38,9 @@
    <iconset resource="../../../vmisc/share/resources/icon.qrc">
     <normaloff>:/icon/32x32/edit.png</normaloff>:/icon/32x32/edit.png</iconset>
   </property>
+  <property name="sizeGripEnabled">
+   <bool>true</bool>
+  </property>
   <property name="modal">
    <bool>true</bool>
   </property>