refactor: revise code for improved readability and maintainability (#86)

FajarKim · Nov 4, 2023 · ec3413a · ec3413a
1 parent 6cf953d
commit ec3413a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/common/utils.ts b/src/common/utils.ts
@@ -2,7 +2,7 @@ function isValidHexColor(hexColor: any): boolean {
   return new RegExp(
     /^([A-Fa-f0-9]{8}|[A-Fa-f0-9]{6}|[A-Fa-f0-9]{3}|[A-Fa-f0-9]{4})$/
   ).test(hexColor);
-};
+}
 
 function isValidGradient(hexColors: string[]): boolean {
   const colors = [hexColors];
@@ -12,7 +12,7 @@ function isValidGradient(hexColors: string[]): boolean {
     }
   }
   return true;
-};
+}
 
 function parseBoolean(value: boolean | string): boolean | undefined {
   if (typeof value === "boolean") {
@@ -27,7 +27,7 @@ function parseBoolean(value: boolean | string): boolean | undefined {
     }
   }
   return undefined;
-};
+}
 
 export {
   isValidHexColor,

diff --git a/src/fetcher/apiFetch.ts b/src/fetcher/apiFetch.ts
@@ -65,7 +65,7 @@ export interface RepositoriesContributedTo {
 }
 
 export default async function apiFetch(username: string): Promise<User> {
-  let data = await axios({
+  const data = await axios({
     method: "post",
     url: "https://api.github.com/graphql",
     headers: {

diff --git a/src/fetcher/repositoryFetch.ts b/src/fetcher/repositoryFetch.ts
@@ -20,7 +20,7 @@ export default async function repositoryFetch(
       { length: totalpage },
       async (_, i) => await getPerPageReposData(username, i + 1)
     )
-  ).then((data: any) => {
+  ).then((data: object[]) => {
     data.forEach((repo: any) => {
       stars += repo.stars;
       forks += repo.forks;
@@ -39,7 +39,7 @@ async function getPerPageReposData(
   username: string,
   pageno: number
 ): Promise<object> {
-  let data = await axios({
+  const data = await axios({
     method: "get",
     url: `https://api.github.com/users/${username}/repos?page=${pageno}&per_page=100`,
     headers: {

diff --git a/src/getData.ts b/src/getData.ts
@@ -24,13 +24,13 @@ export type GetData = {
 };
 
 async function getData(username: string): Promise<GetData> {
-  let user = await apiFetch(username);
-  let totalRepoPages = Math.ceil(user.repositories.totalCount / 100);
-  let userRepositories = await repositoryFetch(username, totalRepoPages);
+  const user = await apiFetch(username);
+  const totalRepoPages = Math.ceil(user.repositories.totalCount / 100);
+  const userRepositories = await repositoryFetch(username, totalRepoPages);
 
   if (!user.name) user.name = user.login;
 
-  let output = {
+  const output = {
     username: user.login,
     name: user.name,
     pic: await base64ImageFetcher.encode(`${user.avatarUrl}&s=200`, {