Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pimd: Candidate RP/BSR preparation #15969

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

pimd: Candidate RP/BSR preparation #15969

wants to merge 5 commits into from

Conversation

eqvinox
Copy link
Contributor

@eqvinox eqvinox commented May 8, 2024 •
edited

Please refer to individual commits.

Fixes that got accumulated during C-RP/C-BSR development:

  • DR priority range was wrong, 0 is valid
  • sending null registers before register stop age-out wasn't quite working right
  • order of update ops for join evaluation was slightly off
  • "no path to RP" wrongly rejects valid configurations

Preparations for C-RP/C-BSR:

  • make clang-format not wreck the YANG module lists
  • print a debug if we're RP ourselves (helpful when debugging C-RP)
  • allow sending unicast PIM packets that are routed normally by the kernel (C-RP advertisements)
  • pre-plumb in the NHT infrastructure for BSRs to track C-RPs

@eqvinox
Copy link
Contributor Author

eqvinox commented May 8, 2024

CI "Verify Source" complains about "do not add new typedefs"

⇒ we use typedefs for pim ipv4<>ipv6 switching

donaldsharp
donaldsharp reviewed May 8, 2024
View reviewed changes
pimd/pim_upstream.c Outdated Show resolved Hide resolved
donaldsharp
donaldsharp reviewed May 8, 2024
View reviewed changes
pimd/pim_upstream.c Outdated Show resolved Hide resolved
donaldsharp
donaldsharp reviewed May 8, 2024
View reviewed changes
pimd/pim6_cmd.c Outdated Show resolved Hide resolved
donaldsharp
donaldsharp reviewed May 8, 2024
View reviewed changes
pimd/pim_cmd.c Outdated Show resolved Hide resolved
donaldsharp
donaldsharp reviewed May 8, 2024
View reviewed changes
pimd/pim_nb_config.c Outdated Show resolved Hide resolved
@eqvinox eqvinox force-pushed the pim-fixes-20240508-cand-rp-bsr-prep branch 2 times, most recently from 90836e6 to 039f5eb Compare May 8, 2024 19:57
@Jafaral Jafaral self-requested a review May 8, 2024 20:10
@Jafaral
Copy link
Member

Jafaral commented May 8, 2024

@eqvinox , does it make sense to split the fixes into a separate PR so we can backport those to older branches? You have already made the effort to put those in separate commits :)

@Jafaral
Copy link
Member

Jafaral commented May 8, 2024 •
edited

Also, why did you not include pimd: no path to RP is not an error ?

UPDATE: I did see @donaldsharp's comment.

@eqvinox eqvinox mentioned this pull request May 9, 2024
Merged
@eqvinox
Copy link
Contributor Author

eqvinox commented May 9, 2024

fixes split into #15975

Jafaral added a commit that referenced this pull request May 9, 2024
@Jafaral
Merge pull request #15975 from opensourcerouting/pim-fixes-20240508
0c9ce7a 
pimd: fixes split off from #15969
This was referenced May 9, 2024
Closed
Closed
Merged
Merged
Merged
@Jafaral Jafaral changed the title pimd: batch of fixes & Candidate RP/BSR preparation pimd: Candidate RP/BSR preparation May 9, 2024
@eqvinox
pimd: make clang-format slightly less annoying
9202b6a 
The YANG module list is really better as 1-item-per-line.

Signed-off-by: David Lamparter <[email protected]>
@eqvinox
pimd: add debugs for i-am-RP state
1004ab0 
This proved helpful in debugging the Candidate-RP code.

Signed-off-by: David Lamparter <[email protected]>
@eqvinox
pimd: add prefix_* and IANA_AFI v4/v6 defines
8bfe512 
The Candidate-RP code is about to use these.

Signed-off-by: David Lamparter <[email protected]>
@eqvinox
pimd: allow sending packets without pinned iface
1032d50 
The upcoming Candidate-RP code needs to send PIM packets that go through
normal unicast routing, without forcing a specific output interface.
Allow passing in NULL ifp to do that.

Signed-off-by: David Lamparter <[email protected]>
@eqvinox
pimd: prepare NHT for tracking BSM C-RPs
36fd6da 
For BSMs, we should track which of the RP candidates in the BSM message
are actually available, before trying to use them (which also puts them
in NHT for that).  This applies for both BSRs as well as BSM receivers.

Signed-off-by: David Lamparter <[email protected]>
@eqvinox eqvinox force-pushed the pim-fixes-20240508-cand-rp-bsr-prep branch from 039f5eb to 36fd6da Compare May 9, 2024 16:44
@github-actions github-actions bot added size/M and removed size/L labels May 9, 2024
Jafaral added a commit that referenced this pull request May 9, 2024
@Jafaral
Merge pull request #15984 from FRRouting/mergify/bp/stable/9.1/pr-15975
629118a 
pimd: fixes split off from #15969 (backport #15975)
donaldsharp added a commit that referenced this pull request May 9, 2024
@donaldsharp
Merge pull request #15983 from FRRouting/mergify/bp/stable/9.0/pr-15975
f32aa08 
pimd: fixes split off from #15969 (backport #15975)
donaldsharp added a commit that referenced this pull request May 9, 2024
@donaldsharp
Merge pull request #15985 from FRRouting/mergify/bp/stable/10.0/pr-15975
35d0c9a 
pimd: fixes split off from #15969 (backport #15975)
ton31337 added a commit that referenced this pull request May 11, 2024
@ton31337
Merge pull request #15990 from Jafaral/pim-fixes
50f5155 
pimd: fixes split off from #15969 (backport #15975)
ton31337 added a commit that referenced this pull request May 13, 2024
@ton31337
Merge pull request #15992 from Jafaral/pim-fixes-8.4
baf6a9d 
pimd: fixes split off from #15969 (backport #15975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldsharp donaldsharp donaldsharp left review comments

@Jafaral Jafaral Awaiting requested review from Jafaral

Assignees
No one assigned
Labels
bugfix master pim size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eqvinox @Jafaral @donaldsharp