Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Feat/limelight #21

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Feat/limelight #21

wants to merge 40 commits into from

Conversation

NotSimon5673
Copy link

Harper sux cause he is a freshman.

Pr for limelight code

Copy link
Member

@KenwoodFox KenwoodFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This never even gets instantiated, also .installer_config should be ignored. If this is not ready for review, please mark it as a draft.

@KenwoodFox KenwoodFox changed the base branch from main to feat/auto-kenwoodfox February 14, 2023 15:35
Copy link
Member

@KenwoodFox KenwoodFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More needs to be done here, but please wait for #12 and #16 to merge ahead

Comment on lines 23 to 32
def getTag(self):
"""Tries to get any apriltag in view of limelight. returns 0 if no apriltag is found."""
tagID = self.table.getEntry("tid").getDouble(0)
tagPos = self.table.getEntry("targetpose_robotspace").getDoubleArray(0)
self.map["fiducials"][tagID - 1]["transform"] = tagPos
return tagPos

def getBotPos(self):
pos = self.table.getEntry("botpose_targetspace").getDoubleArray(0)
return pos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These never get called

Base automatically changed from feat/auto-kenwoodfox to feat/auto February 14, 2023 18:28
Base automatically changed from feat/auto to main February 14, 2023 18:36
Jack Jewett and others added 6 commits February 14, 2023 20:29
…nd via networktables. It probably won't work though so isk
…d drive until reaches up to the tag. the values will have to be adjusted
… code not to work, if this is'nt it and it still returns 0 it might just be an issue of networktables not working.
…drive up and stop at the station. more code coming soon
.gitignore Show resolved Hide resolved
.gitignore Show resolved Hide resolved
.gitignore Show resolved Hide resolved
.gitignore Show resolved Hide resolved
.gitignore Show resolved Hide resolved
dashboard/entrypoint.sh Show resolved Hide resolved
dashboard/src/main.js Show resolved Hide resolved
dashboard/src/main.js Show resolved Hide resolved
Jack Jewett added 4 commits March 15, 2023 18:20
…ocus

-Added comments to make code more understandable and cohesive

-got rid of unnecessary/broken functions
…priltag. just committing now so I can start on color detection
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants