This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/limelight #21
Open
NotSimon5673
wants to merge
40
commits into
main
Choose a base branch
from
feat/limelight
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/limelight #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uto spinning but they breaks the drivetrain into spinning
Todo: Not characterized, all these physics numbers are kinda just made up
KenwoodFox
suggested changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This never even gets instantiated, also .installer_config
should be ignored. If this is not ready for review, please mark it as a draft.
NotSimon5673
force-pushed
the
feat/limelight
branch
from
February 14, 2023 01:02
a100c40
to
e186aa5
Compare
…ate the transform values of an fmap file. this function will prove better than getpos() during testing but in comp it's not the most useful due to getpos existing
…est out the code.
NotSimon5673
force-pushed
the
feat/limelight
branch
from
February 14, 2023 14:27
5399390
to
03dc676
Compare
KenwoodFox
suggested changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rio/autonomous/limelight.py
Outdated
Comment on lines
23
to
32
def getTag(self): | ||
"""Tries to get any apriltag in view of limelight. returns 0 if no apriltag is found.""" | ||
tagID = self.table.getEntry("tid").getDouble(0) | ||
tagPos = self.table.getEntry("targetpose_robotspace").getDoubleArray(0) | ||
self.map["fiducials"][tagID - 1]["transform"] = tagPos | ||
return tagPos | ||
|
||
def getBotPos(self): | ||
pos = self.table.getEntry("botpose_targetspace").getDoubleArray(0) | ||
return pos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These never get called
…nd via networktables. It probably won't work though so isk
…d drive until reaches up to the tag. the values will have to be adjusted
… code not to work, if this is'nt it and it still returns 0 it might just be an issue of networktables not working.
…drive up and stop at the station. more code coming soon
KenwoodFox
suggested changes
Mar 9, 2023
…ocus -Added comments to make code more understandable and cohesive -got rid of unnecessary/broken functions
…priltag. just committing now so I can start on color detection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harper sux cause he is a freshman.
Pr for limelight code