Skip to content

Commit

Permalink
Style fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
greenc-FNAL committed Oct 15, 2024
1 parent 7ebc313 commit 0cecee9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
3 changes: 1 addition & 2 deletions var/spack/repos/builtin/packages/llvm/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ class Llvm(CMakePackage, CudaPackage, LlvmDetection, CompilerPackage):

patch("sanitizer-platform-limits-posix-xdr-macos.patch", when="@10:14 platform=darwin")

patch("llvm-cmake-modules-FindZ3.patch", level=0, when="@14.0.6")
patch("llvm-cmake-modules-FindZ3.patch", level=0, when="@14.0.6")

@when("@14:17")
def patch(self):
Expand All @@ -647,7 +647,6 @@ def patch(self):
string=True,
)


compiler_version_regex = (
# Normal clang compiler versions are left as-is
r"clang version ([^ )\n]+)-svn[~.\w\d-]*|"
Expand Down
8 changes: 5 additions & 3 deletions var/spack/repos/builtin/packages/py-tensorflow/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -459,14 +459,16 @@ class PyTensorflow(Package, CudaPackage, ROCmPackage, PythonExtension):
)
# Fix for compiling with clang 18 which produces the following error
# See https://github.com/tensorflow/tensorflow/issues/62416
# ld.lld: error: version script assignment of 'global' to symbol 'init_pywrap_tf2' failed: symbol not defined
# ld.lld: error: version script assignment of 'global' to symbol 'init__pywrap_tf2' failed: symbol not defined
# ld.lld: error: version script assignment of 'global' to symbol 'init_pywrap_tf2' failed:
# symbol not defined
# ld.lld: error: version script assignment of 'global' to symbol 'init__pywrap_tf2' failed:
# symbol not defined
# clang: error: linker command failed with exit code 1 (use -v to see invocation)
# Target //tensorflow/tools/pip_package:build_pip_package failed to build
patch(
"https://raw.githubusercontent.com/getsolus/packages/dfc56ba57a8af8233a635e309b499ff5d27992f4/packages/t/tensorflow/files/fix-clang-18.diff",
sha256="10d730b59284843d6c9ba92668b068582e51d5cdfc7ccfe8e26791ad0f41d4ac",
when="@2.15.0"
when="@2.15.0",
)
phases = ["configure", "build", "install"]

Expand Down

0 comments on commit 0cecee9

Please sign in to comment.