Add task verifier display to ui and all related interfaces #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neumantm
force-pushed
the
feature/task-verifier
branch
from
a83c964 to
07b93f1
Compare
|
Did not add any changes in the force push. Just trying to get travis to run on the PR |
neumantm
requested changes
Jul 19, 2020
| @@ -101,8 +101,8 @@ public void close() throws IOException { | |||
|
|
|||
| @Override | |||
| public void write(final int character) throws IOException { | |||
| char symbol = (char) character; | |||
There was a problem hiding this comment.
Please try to avoid unrelated changes in the future.
I think it is better to just open a separate PR for these. (It will be small and reviewed+merged quickly)
The problem is: Now blame will show a commit, which should have nothing to do with this class.
There was a problem hiding this comment.
But you can leave it in this PR now.
...alStart/src/main/java/de/unistuttgart/informatik/fius/icge/manualstart/TestTaskVerifier.java
Show resolved
Hide resolved
...alStart/src/main/java/de/unistuttgart/informatik/fius/icge/manualstart/TestTaskVerifier.java
Outdated
Show resolved
Hide resolved
ICGE-Ui/src/main/java/de/unistuttgart/informatik/fius/icge/ui/TaskInformation.java
Outdated
Show resolved
Hide resolved
...i/src/main/java/de/unistuttgart/informatik/fius/icge/ui/internal/SwingTaskStatusDisplay.java
Outdated
Show resolved
Hide resolved
...i/src/main/java/de/unistuttgart/informatik/fius/icge/ui/internal/SwingTaskStatusDisplay.java
Show resolved
Hide resolved
neumantm
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a task status display to the ui as a task status tab next to the console tab.
The task verification status needs to be refreshed manually using the refresh button.
The task information model allows nested tasks with their own verification status.
Closes #144
Related to #135