-
-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serial protocol channel mapper #2801
base: master
Are you sure you want to change the base?
Serial protocol channel mapper #2801
Conversation
@pkendall64 is this what you expected? |
3084389
to
51c19f6
Compare
tested with oscilloscope, all ok |
This is on the right track, but I think the UI part will need some work. We need to somehow merge the PWM and channel mapping together to create a concise simple UI for users. |
I was thinking about that - and did separate channel list for serial, reasons:
What I tried as well and looked slightly better was to have 2 columns with 2 channels per row. Should I prepare 2nd PR with Serial config in the upper config part? |
@pkendall64: prepared updated preview: For me is the original bit less confusing. |
Yeah, maybe the second is clearer. Another issue is that we now have 2 potential serial outputs. So it may be better to relabel the columns, and hide the column is that serial is not configured and hide the entire section if no serial output is configured.
Or something similar. |
Not 100% sure, what second mean :-) I will add 2nd serial option as well the LQ and RSSIdbm. But I need a bit of guidance - how to map both values to CRSF/SBUS/other serial protocols. |
second was referring to the second screenshot, in the seperate section. |
Just to be completely sure - separate section with 1 column. How what about the mapping of RSSI and LQ mapping? |
and one more question - what is a good receiver with possibility of 2 serial ports? |
The BetaFPV SuperP 14 channel receiver is a good one. You can configure the second serial on any of the pins. |
@pkendall64 who was doing the webUI things for serial port? It's a bit mess, the updates now are coming from various sources - Airport settings, Serial, Serial 2, etc. What would be better solution - small refactor or introduction of a small controller handling all the events and getting UI in one state (showing/hiding the particular config options?). |
Please consider a more general approach which mixes the incoming channels so it is not serial output specific. I've been working on a generic mixer to support RX gyros #2869 |
ok, will do... summer break now, but might get to finish that next week :-) |
any action here? |
Indeeed- very keen on this as well. (sbus remapping etc) |
The dev team are investigating/working on removing the ARM channel requirement completely for full-res modes.So that will remove the need for all this complication with channel mapping. |
Possibility to map serial channels to allow exclusion of CH5 for fixed wings gyros.
Previous pull was rejected, so tried to implement based on the recommendation.