removed check for prefix so we can fallback to empty

[patduin]

fixes #173

[massdosage]

It almost looks... too.... easy!

[AnanaMJ]

Two new lines 😱

[AnanaMJ]

(although it's not visible in the formatted version :) )

[patduin]

...to easy indeed. Found a conundrum in UDFs.
Leaving out the prefix for a udf won't work. At least not in a Hive CLI (Not sure how this works in other clients (Spark,Qubole etc..)). Hive CLI fetches all UDFs on startup (or reload function command). They are registered with prefix. So when calling show functions you get prefix_db.functionName.
In order for a select db.functionName to work we'll need to return that particular function name. We need to return both prefix_db.functionName and db.functionName when loading the functions. This means show functions will show both which is something we don't really want.
I don't think there is any way around this though when using a function (e.g. select...) there is no Metastore call to proxy it just looks up the loaded functions in the client and fails if it cannot locate a function with that name.

We need to choose either list functions prefixed and non-prefixed or force prefixed UDFs only. Thoughts/preferences anyone?

[abhimanyugupta07]

...to easy indeed. Found a conundrum in UDFs.
Leaving out the prefix for a udf won't work. At least not in a Hive CLI (Not sure how this works in other clients (Spark,Qubole etc..)). Hive CLI fetches all UDFs on startup (or reload function command). They are registered with prefix. So when calling show functions you get prefix_db.functionName.
In order for a select db.functionName to work we'll need to return that particular function name. We need to return both prefix_db.functionName and db.functionName when loading the functions. This means show functions will show both which is something we don't really want.
I don't think there is any way around this though when using a function (e.g. select...) there is no Metastore call to proxy it just looks up the loaded functions in the client and fails if it cannot locate a function with that name.

We need to choose either list functions prefixed and non-prefixed or force prefixed UDFs only. Thoughts/preferences anyone?

I think I prefer showing both in show functions rather than having inconsistent behaviour when compared with rest of the queries where we are defaulting to db when no prefix is provided in the query.

[patduin]

I think I prefer showing both in show functions rather than having inconsistent behaviour when compared with rest of the queries where we are defaulting to db when no prefix is provided in the query.

The problem with showing both (same when showing both db's) is that it looks weird and user might think hey that looks wrong I'll delete on (which will delete both). :(

[abhimanyugupta07]

I think I prefer showing both in show functions rather than having inconsistent behaviour when compared with rest of the queries where we are defaulting to db when no prefix is provided in the query.

The problem with showing both (same when showing both db's) is that it looks weird and user might think hey that looks wrong I'll delete on (which will delete both). :(

True. But deleting a function is not as big of a problem compared to deleting a table or database. Out of the two options, if you choose the one where you force people to use prefix, again the issue of backward compatibility will arise and also a user will be confused that for everything else my query works but for functions, its not working. I feel it's inconsistent from an end-user perspective. Also (I am guessing here) show functions might not be a commonly used query, so this might not be that big of a problem if we show both options only for this query.

[massdosage]

Remind me what happens when one does "show databases" in this case - do we only see the prefixed ones?

[patduin]

Remind me what happens when one does "show databases" in this case - do we only see the prefixed ones?

yes.