Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added automatic labeler system #2670

Merged
merged 11 commits into from
Jul 12, 2024
Merged

Added automatic labeler system #2670

merged 11 commits into from
Jul 12, 2024

Conversation

iamalexrouse
Copy link
Member

@iamalexrouse iamalexrouse commented Jul 3, 2024 •
edited
Loading

This PR adds an automatic labeling system which detects modifications to certain files or folders & applies the respective label.

This can be adjusted but is here to provide a starting point to understand how the workflow works.

image

  • Pull Requests which modify ./Exiled.API receives the API tag.
  • Pull Requests which modify ./Exiled.CustomModules receives the CustomModules tag.
  • Pull Requests which modify ./Exiled.Events receives the Events tag.
  • Pull Requests which modify ./Exiled.Installer receives the Installer tag.
  • Pull Requests which modify **/*.nuspec receives the NuGet tag.
  • Pull Requests which modify **/*.p1 or **/*.p1 receives the Scripts tag.
  • Pull Requests which modify ./docs receives the docs tag.

NOTE: This WILL create new labels if they don't exist, so if you want to reassign each one to a preexisting one, you'll want to replace the label names.

@iamalexrouse iamalexrouse marked this pull request as ready for review July 3, 2024 13:22
@VladTheCow
Copy link
Contributor

An interesting idea, can you test it on your repo?

@iamalexrouse
Copy link
Member Author

An interesting idea, can you test it on your repo?

https://github.com/ALEXWARELLC/I-should-become-a-dev-for-doing-everything-nameless-doesnt/issues/5

@NaoUnderscore
Copy link
Collaborator

Great, I love it. Is there any chance we can use existing ones? In order to keep consistency with older PRs.

@iamalexrouse
Copy link
Member Author

Great, I love it. Is there any chance we can use existing ones? In order to keep consistency with older PRs.

Yeah, of course. This can be customised all the way down to a file specific level.

I'll try to use the pre-existing labels if possible.

@NaoUnderscore
Copy link
Collaborator

Is there any chance to rename the PR by prepending the [Exiled.Module] prefix?

@iamalexrouse
Copy link
Member Author

iamalexrouse commented Jul 5, 2024 •
edited
Loading

Is there any chance to rename the PR by prepending the [Exiled.Module] prefix?

If the files affected include the modules project, then I can write a step to rename the PR with the [Exiled.Modules] prefix.

The issue comes in when files in different projects cause conflicts, which means it would need to wither add the many different prefixes or prioritize a certain prefix over the others.

@iamalexrouse
Create pull_request_reviewed.yml (#8)
d68b761 
This adds a `approved` label to PRs which have been approved by reviewers.
@iamalexrouse
Copy link
Member Author

Is there any chance to rename the PR by prepending the [Exiled.Module] prefix?

Update: Unfortunately, I can't figure out how to name PRs.
There is little, to no documentation on how to rename pull requests.

@iamalexrouse
bye bye
7501219 
💥
@louis1706
Copy link
Member

Very great idea

@Misfiy Misfiy added tested This PR has been built and tested and does not cause any obvious errors. P3 Low Priority labels Jul 8, 2024
@Misfiy Misfiy requested a review from NaoUnderscore July 8, 2024 16:54
@iamalexrouse iamalexrouse marked this pull request as draft July 10, 2024 10:35
@iamalexrouse
Copy link
Member Author

iamalexrouse commented Jul 10, 2024 •
edited
Loading

I've thought and will not put too much thought into this.

@iamalexrouse iamalexrouse marked this pull request as ready for review July 12, 2024 19:06
@NaoUnderscore NaoUnderscore merged commit 68fb494 into Exiled-Team:master Jul 12, 2024
3 checks passed
NaoUnderscore added a commit that referenced this pull request Jul 13, 2024
@NaoUnderscore @iamalexrouse @Monaldcry7788
Merge master into dev (#2699)
5820291 
* Added automatic labeler system  (#2670)

* Create pull_request_opened.yml

Add Pull Request Labeler.

* Add Labeler configuratino

* Update labeler.yml

* Update pull_request_opened.yml

* Erm, skill Issue

* Added transpiler detection support.

* Create pull_request_reviewed.yml (#8)

This adds a `approved` label to PRs which have been approved by reviewers.

* bye bye

💥

* Update pull_request_opened.yml

* Update pull_request_opened.yml

---------

Co-authored-by: Nao <[email protected]>

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update README.md

* Thanks Benjamin

* Updated ReadME (#2696)

* Update README-中文.md

* Update README-ไทย.md

* Update README-TR.md

* Update README-PL.md

* Update README-KR.md

* Update README-IT.md

* Update README-FR.md

* Update README-ES.md

* Update README-DK.md

* Update README-DE.md

* Update README-CS.md

* Update README-BR.md

* Update GettingStarted-ไทย.md

* Update GettingStarted-KR.md

* Update GettingStarted-FR.md

* Update GettingStarted-BR.md

* Update MoreEffectiveCoroutines.md

* Update README-Русский.md

* Update README-中文.md

* Update README-ไทย.md

* Update README-TR.md

* Update README-PL.md

* Update README-KR.md

* Update README-IT.md

* Update README-FR.md

* Update README-ES.md

* Update README-DK.md

* Update README-DE.md

* Update README-CS.md

* Update README-BR.md

* Update README-中文.md

* Update README-ไทย.md

* Update README-Русский.md

* Update README-TR.md

* Update README-PL.md

* Update README-KR.md

* Update README-IT.md

* Update README-FR.md

* Update README-ES.md

* Update README-DK.md

* Update README-DE.md

* Update README-CS.md

* Update README-BR.md

---------

Co-authored-by: Nao <[email protected]>

---------

Co-authored-by: Alex Rouse <[email protected]>
Co-authored-by: Monald <[email protected]>
NaoUnderscore added a commit that referenced this pull request Jul 13, 2024
@NaoUnderscore @iamalexrouse @Monaldcry7788
agpl v3 (#2700)
e59f9d8 
* Added automatic labeler system  (#2670)

* Create pull_request_opened.yml

Add Pull Request Labeler.

* Add Labeler configuratino

* Update labeler.yml

* Update pull_request_opened.yml

* Erm, skill Issue

* Added transpiler detection support.

* Create pull_request_reviewed.yml (#8)

This adds a `approved` label to PRs which have been approved by reviewers.

* bye bye

💥

* Update pull_request_opened.yml

* Update pull_request_opened.yml

---------

Co-authored-by: Nao <[email protected]>

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update pull_request_opened.yml

* Update README.md

* Thanks Benjamin

* Updated ReadME (#2696)

* Update README-中文.md

* Update README-ไทย.md

* Update README-TR.md

* Update README-PL.md

* Update README-KR.md

* Update README-IT.md

* Update README-FR.md

* Update README-ES.md

* Update README-DK.md

* Update README-DE.md

* Update README-CS.md

* Update README-BR.md

* Update GettingStarted-ไทย.md

* Update GettingStarted-KR.md

* Update GettingStarted-FR.md

* Update GettingStarted-BR.md

* Update MoreEffectiveCoroutines.md

* Update README-Русский.md

* Update README-中文.md

* Update README-ไทย.md

* Update README-TR.md

* Update README-PL.md

* Update README-KR.md

* Update README-IT.md

* Update README-FR.md

* Update README-ES.md

* Update README-DK.md

* Update README-DE.md

* Update README-CS.md

* Update README-BR.md

* Update README-中文.md

* Update README-ไทย.md

* Update README-Русский.md

* Update README-TR.md

* Update README-PL.md

* Update README-KR.md

* Update README-IT.md

* Update README-FR.md

* Update README-ES.md

* Update README-DK.md

* Update README-DE.md

* Update README-CS.md

* Update README-BR.md

---------

Co-authored-by: Nao <[email protected]>

* Update LICENSE.md

---------

Co-authored-by: Alex Rouse <[email protected]>
Co-authored-by: Monald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaoUnderscore NaoUnderscore Awaiting requested review from NaoUnderscore

Assignees

@iamalexrouse iamalexrouse

Labels
P3 Low Priority tested This PR has been built and tested and does not cause any obvious errors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iamalexrouse @VladTheCow @NaoUnderscore @louis1706 @Misfiy