Collection extensions upd

[Banalny-Banan]

Shuffle<T>(this IEnumerable<T> enumerable, int iterations = 1) - added documentation for thrown exceptions & added an actual shuffle instead of infinite recursive call

AddRange<T>(this IEnumerable<T> enumerable, IEnumerable<T> collection) - before was calling AddItem() in a loop. (multiple Concat()s internaly). It wouldnt even work because AddItem() is a pure method. Now using one Concat().

AddRange<T>(this T[] array, IEnumerable<T> collection) - same changes.

AddRange<T>(this HashSet<T> hashset, IEnumerable<T> collection) - before was calling Add() in a loop. Now using UnionWith().

[Banalny-Banan]

I think there is also an issue with inconsistent null-checks - some methods throw exceptions (like Shuffle), some return default values (like Random).
I dont know if this is intensional, so didnt fix it.
Should i ?

[Banalny-Banan]

That is to avoid calling .ToArray() if enumerable is a generic List<>. Arrays implement IList<> as well -
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/arrays#1723-arrays-and-the-generic-collection-interfaces

[Banalny-Banan]

Maybe we should add an "Instance" field to Plugin<> class instead of making all those GetPlugin() methods ?
I remember it existing in the example plugin and assigned in OnEnabled()
We could just do it in base class

[iamalexrouse]

Maybe we should add an "Instance" field to Plugin<> class instead of making all those GetPlugin() methods ? I remember it existing in the example plugin and assigned in OnEnabled() We could just do it in base class

Isn't this outside the scope of the PR?

[VALERA771]

Use a Nw extension (ShuffleList)

[iamalexrouse]

I'm ok with this

[VALERA771]

Okay. Now you need to target dev branch (read exiled announcements if any questions)