fix-date1904Attribute bool parsing possibility appointed on issue #649 #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom xl/worbook.xml. The only two possible values that excel recognises are "true" and "1" also, pattern matching is more readable than equals "==" aldo this can be easily changed if breaks the project pattern. ExcelDataReader#649 third solve suggestion
xl/workbook.xml > workbookPr > date1904 attribute
eJJonatah
changed the title
eJJonatah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As demonstrated in the issue example, scheffer, from oracle using a database procedure to generating a .xlsx report sets the
attribute date1904 in tag workbookPr as a "true" literal value instead of "1" already known pattern. I tested other possibilities that can be seen in the file Test_Issue_649_Date1904_Parsings's internal xmls and found out that the only values recognized by
excel are "1" and "true", since any other possibility will not display dates correcly in the excel's interface.
I put pattern matching because i think its more readable than the equals operator but that can be easily edited to mantain the
project pattern.
Closes: #649