[FEAT] Read parquet tables with int96 coercion option #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue filed in arrow2: jorgecarleitao/arrow2#1527 |
jaychia
changed the title
jaychia
commented
Aug 8, 2023
| @@ -94,33 +95,30 @@ impl ParquetReaderBuilder { | |||
|
|
|||
| let metadata = read_parquet_metadata(uri, size, io_client).await?; | |||
| let num_rows = metadata.num_rows; | |||
| let schema = | |||
There was a problem hiding this comment.
NOTE: schema inference is now deferred to only when .build() is called
This allows the builder to make better decisions about whether it needs to infer the schema (i.e. did the user provide one?) and, if so, how it should infer the schema (what flags did the user provide)?
jaychia
force-pushed
the
jay/timestamp-int96-overflow
branch
from
bb47bb9
to
657986c
Compare
added 6 commits
August 7, 2023 18:57
jaychia
force-pushed
the
jay/timestamp-int96-overflow
branch
from
657986c
to
65852b6
Compare
jaychia
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1231 +/- ##
==========================================
- Coverage 87.69% 87.26% -0.44%
==========================================
Files 56 62 +6
Lines 5698 5944 +246
==========================================
+ Hits 4997 5187 +190
- Misses 701 757 +56
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to coerce int96 timestamps to a specific TimeUnit during reads of Parquet