Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the handling to global request responses differs between Client and Server.
At the moment, the only situation where we receive those is in response to keepalive requests (everything else is sent with want_reply false), so I've also added a little bit of an explaining comment instead of a leftover "todo".
The old
if
is not really sufficient to filter for global requests in response to keepalives, since the value it checks,alive_timeouts
is reset to 0 with the first response, but due to TCP resends multiple keepalives and their responses might arrive.This also stops russh client from repeatedly sending an
info
-level log message about an unknown packet when keepalive responses are received, downgrading unknown messages todebug
in general (same as it was in server already), andREQUEST_SUCCESS
/REQUEST_FAILURE
totrace
.